Repository navigation
Show the report-level rejected message in the expense report preview - #99124
Conversation
Report level rejection only updates the report state and its next step, so the chat preview had no consumer for it and looked like an ordinary draft. Render the existing rejected report message when the report is open with a rejectedReport next step, matching the Spend list.
|
@Krishna2323 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
@Krishna2323 kindly bump |
|
Will start reviewing today. |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppandroid_hybrid.mp4Android: mWeb Chromeandroid_mWeb.mp4iOS: HybridAppios_hybrid.mp4iOS: mWeb Safariios_mWeb.mp4MacOS: Chrome / Safariweb_chrome.mp4 |
|
@roryabraham one follow-up on this:
The PR does this for the chat preview, and I verified it works for both submitter and approver. But on the Reports page, it's only shown when the viewer owns the report. So as an approver, I see it in chat but not on the Reports page for the same report. This check has been there since #84853, but I couldn't find a reason for it. Should the Reports page match chat, or is the owner-only behavior intentional? It's a one-line change to make them consistent. Lines 3139 to 3142 in 91ee30c |
Let's make them consistent 👍🏼 |
…ipant The chat preview shows it to everyone on the report, so drop the owner check that kept it hidden from approvers in the Reports list.
|
@Krishna2323 adjusted it. mind continuing review, pls?! |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/roryabraham in version: 9.4.69-0 🚀
|
|
Yes — help site changes are required, and I've opened a draft PR for them: #100234 This PR surfaces the message What changed in the docs
UI labels verified against the live app (web)I ran the full reject flow on web — created a workspace with approvals, submitted a 2-expense report, then rejected it back to the submitter — and confirmed each label before writing:
The articles follow One thing I couldn't do: GitHub rejected @mukhrr, please review the linked help site PR and confirm it reflects the current behavior. Then mark the linked help site PR |
|
🚧 roryabraham has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to production by https://github.com/francoisl in version: 9.4.69-1 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
Report-level rejection only moves the report back to
OPENwith arejectedReportnext step, no per-expense violations (intentional). The Spend list already renders "This report was rejected." from that state, the chat preview never did, so a rejected report looked like a plain draft.This renders the same message in
MoneyRequestReportPreview, between the carousel and the action button (mock). No violation, API or backend changes.Fixed Issues
$ #96996
PROPOSAL: #96996 (comment)
Tests
Offline tests
QA Steps
Same as tests.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari